Differential D20540

Port printing to use the KContact::Email gadget instead of a wrapper
ClosedPublic
Actions

Authored by vkrause on Apr 14 2019, 3:10 PM.

Details

Reviewers

Commits

R82:06e7045231da: Port printing to use the KContact::Email gadget instead of a wrapper

Summary

This does change the theme API, however it has no practical effect as all
themes in KAddressbook are using the emails property wrongly anyway and
thus don't show anything either way.

Diff Detail

Repository

R82 KDE PIM Application Libraries

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Apr 14 2019, 3:10 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 14 2019, 3:10 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.Apr 14 2019, 3:10 PM

Harbormaster completed remote builds in B10847: Diff 56209.Apr 14 2019, 3:10 PM

vkrause mentioned this in D20541: Fix printing of email addresses.Apr 14 2019, 3:13 PM

mlaurent accepted this revision.Apr 14 2019, 5:54 PM

This revision is now accepted and ready to land.Apr 14 2019, 5:54 PM

Closed by commit R82:06e7045231da: Port printing to use the KContact::Email gadget instead of a wrapper (authored by vkrause). · Explain WhyApr 17 2019, 5:03 PM

This revision was automatically updated to reflect the committed changes.

vkrause mentioned this in R204:4f6ed7f87d89: Fix printing of email addresses.Apr 17 2019, 5:13 PM

Revision Contents
Changeset List

		Path
M		kaddressbookgrantlee/src/CMakeLists.txt (1 line)
D	M	kaddressbookgrantlee/src/contactobject/contactgrantleeemail.h (47 lines)
D	M	kaddressbookgrantlee/src/contactobject/contactgrantleeemail.cpp (55 lines)
M		kaddressbookgrantlee/src/formatter/grantleecontactformatter.cpp (1 line)
M		kaddressbookgrantlee/src/printing/contactgrantleeprintobject.h (7 lines)
M		kaddressbookgrantlee/src/printing/contactgrantleeprintobject.cpp (31 lines)
M		kaddressbookgrantlee/src/printing/grantleeprint.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	56209	7e28595		Apr 14 2019, 3:10 PM	★	★
Diff 2	56448	20fa897	R82:06e7045231da4a7eb6bf12edf1a114cae471afa3	Apr 17 2019, 5:03 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
eb1c8e3dfc0d	6ed11129d4cb	7e285957bb4d	Volker Krause	Port printing to use the KContact::Email gadget instead of a wrapper (Show More…)	Apr 14 2019, 3:09 PM