Differential D2054

Fix for bug 364530
ClosedPublic
Actions

Authored by chinmoyr on Jun 30 2016, 3:58 PM.

Details

Reviewers
sebas
dfaure
bshah
Group Reviewers
Plasma
Commits
R871:6911541421dc: Fix files/folders in desktop not opening with right click context menu
R120:6911541421dc: Fix files/folders in desktop not opening with right click context menu
Summary

In plasma-workspace the prepareUDSEntry in file kioslave/desktop/kio_desktop.cpp sets UDS_TARGET_URL as
'entry.insert(KIO::UDSEntry::UDS_TARGET_URL, entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH)'.
Now using UDS_LOCAL_PATH will return the path without file scheme. This schemeless path will be set in UDS_TARGET_URL and then will be used by
kio's targetUrl and then final passed to Krun where it will fail the scheme test eventually leading to the said bug.

What this patch will do is simply create a url using QUrl::fromLocalFile and then pass the url.toString()'s result to insert. This way the bug won't occur.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chinmoyr updated this revision to Diff 4870.Jun 30 2016, 3:58 PM
chinmoyr retitled this revision from to Fix for bug 364530.
chinmoyr updated this object.
chinmoyr edited the test plan for this revision. (Show Details)
chinmoyr added reviewers: sebas, bshah, Plasma.
chinmoyr set the repository for this revision to R120 Plasma Workspace.
chinmoyr added a project: Plasma.
chinmoyr added a subscriber: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJun 30 2016, 3:58 PM
bshah edited edge metadata.Jun 30 2016, 4:09 PM

Is there any bug report for this?

dfaure accepted this revision.Jun 30 2016, 4:21 PM
dfaure added a reviewer: dfaure.
dfaure added a subscriber: dfaure.

Yes, this is a much better fix, thank you.

This revision is now accepted and ready to land.Jun 30 2016, 4:21 PM
bshah accepted this revision.Jun 30 2016, 4:29 PM
bshah edited edge metadata.
In D2054#37927, @chinmoyr wrote:

yes, https://bugs.kde.org/show_bug.cgi?id=364530

Oh sorry, I didn't notice title, my bad. Do you have commit access? or want someone to commit this for you?

chinmoyr added a comment.Jun 30 2016, 4:31 PM

no i don't have commit access.

Closed by commit R120:6911541421dc: Fix files/folders in desktop not opening with right click context menu (authored by chinmoyr, committed by bshah). · Explain WhyJun 30 2016, 4:42 PM
This revision was automatically updated to reflect the committed changes.
bshah added a comment.Jun 30 2016, 4:44 PM
In D2054#37937, @chinmoyr wrote:

no i don't have commit access.

Just committed with slightly proper commit message.. Congratulations on your first patch :-)

Revision Contents
Changeset List

PathPackages
Mkioslave/desktop/kio_desktop.cpp (3 lines)

Diff 4872

View Options

kioslave/desktop/kio_desktop.cpp

Loading...