Differential D20522

Don't load the KSharedConfig instance on every read
ClosedPublic
Actions

Authored by apol on Apr 13 2019, 11:46 PM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
Commits
R116:4408af0c1111: Don't load the KSharedConfig instance on every read
Summary

At the moment it was loading >2000 times at plasma boot for me because some
settings are being used in AppletProxyModel::filterAcceptsRow.

Test Plan

Added a debug statement in KSharedPointer::openFile()

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 13 2019, 11:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 13 2019, 11:46 PM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Apr 13 2019, 11:46 PM
jgrulich accepted this revision.Apr 14 2019, 8:38 AM
This revision is now accepted and ready to land.Apr 14 2019, 8:38 AM
Closed by commit R116:4408af0c1111: Don't load the KSharedConfig instance on every read (authored by apol). · Explain WhyApr 14 2019, 5:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibs/configuration.cpp (17 lines)

Diff 56234

View Options

libs/configuration.cpp

Loading...