KCharSelect: remove unnecessary call
ClosedPublic

Authored by dfaure on Apr 13 2019, 7:23 PM.

Details

Summary

d->_k_sectionSelected() refills the block combo which automatically
sets the current index to 0 (from -1 set by clear) and calls
_k_blockSelected.

Doing it twice is actually expensive since an item model is deleted
and recreated in that method.

Test Plan

ctest (the unittest in the previous patch actually requires
this fix, due to the QHeaderView asserts)

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Apr 13 2019, 7:23 PM
dfaure created this revision.
cfeck accepted this revision.Apr 29 2019, 10:50 PM
This revision is now accepted and ready to land.Apr 29 2019, 10:50 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 3 2019, 5:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript