Differential D20501

packaging macOS: Fix Poppler compile
ClosedPublic
Actions

Authored by vanyossi on Apr 13 2019, 5:13 AM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:98f0804a2784: packaging macOS: Fix Poppler compile
Summary

patch added to fix mismatch on FindPackage iconv as it includes iconv from BUILDROOT but link against system iconv.dylib

Test Plan

Fresh build on poppler.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vanyossi created this revision.Apr 13 2019, 5:13 AM
Restricted Application added a reviewer: Krita. · View Herald TranscriptApr 13 2019, 5:13 AM
Restricted Application added a project: Krita. · View Herald Transcript
vanyossi requested review of this revision.Apr 13 2019, 5:13 AM
rempt accepted this revision.Apr 13 2019, 9:50 AM
This revision is now accepted and ready to land.Apr 13 2019, 9:50 AM
Closed by commit R37:98f0804a2784: packaging macOS: Fix Poppler compile (authored by vanyossi). · Explain WhyApr 14 2019, 4:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56169

View Options

3rdparty/ext_poppler/CMakeLists.txt

Loading...
View Options

3rdparty/ext_poppler/mac_popplerIconv.patch

Loading...
View Options

packaging/macos/osxbuild.sh

Loading...