Differential D20499

Support gzipping of svgz also on windows, using 7z
ClosedPublic
Actions

Authored by kossebau on Apr 12 2019, 8:13 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Windows
Commits
R242:78bec83b222f: Support gzipping of svgz also on windows, using 7z

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 12 2019, 8:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 12 2019, 8:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 12 2019, 8:13 PM
kossebau updated this revision to Diff 56097.Apr 12 2019, 8:19 PM

search both 7z.exe & 7za.exe

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2019, 8:49 PM
Closed by commit R242:78bec83b222f: Support gzipping of svgz also on windows, using 7z (authored by kossebau). · Explain Why
This revision was automatically updated to reflect the committed changes.
kossebau added a comment.Apr 12 2019, 8:50 PM

Given CI is currently broken for Windows, going for try & error, as usually windows experts to review are hard to find.

cullmann added a subscriber: cullmann.Apr 12 2019, 8:52 PM

I glanced at it, thought I have at home no Windows machine at hand to test if the command line works as planned.

vonreth added a subscriber: vonreth.Apr 12 2019, 9:22 PM

7z will be around as it is the second core (craft) dep after wget😊

Revision Contents
Changeset List

PathPackages
AMcmake/Find7z.cmake (47 lines)
Msrc/desktoptheme/CMakeLists.txt (48 lines)

Diff 56098

View Options

cmake/Find7z.cmake

Loading...
View Options

src/desktoptheme/CMakeLists.txt

Loading...