Differential D20491

Rewrite applicationjobs dataengine to work with libnotificationmanager
ClosedPublic
Actions

Authored by broulik on Apr 12 2019, 11:54 AM.

Details

Reviewers

sitter

Group Reviewers

Plasma

Summary

Keeps it mostly working for compatibility.

Test Plan

Depends on D20265

Copied a file in Dolphin, got task bar progress.
Tested the old notification plasmoid, showed copy progress and details (source, dest, number of files etc) just fine and I could pause and cancel jobs from it

Diff Detail

Repository

R120 Plasma Workspace

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Apr 12 2019, 11:54 AM

Restricted Application added a project: Plasma. · View Herald TranscriptApr 12 2019, 11:54 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Apr 12 2019, 11:54 AM

mart added a subscriber: mart.Apr 24 2019, 11:52 AM

mart added inline comments.

dataengines/applicationjobs/kuiserverengine.cpp
80	this is actually needed for retrocompatibility

broulik marked an inline comment as done.May 8 2019, 11:35 AM

All merged https://cgit.kde.org/plasma-workspace.git/commit/?id=3c52fc3bc05e0f351d4998ad54edae1a4e21a043

sitter accepted this revision.May 9 2019, 2:00 PM

This revision is now accepted and ready to land.May 9 2019, 2:00 PM

sitter closed this revision.May 9 2019, 2:01 PM

Revision Contents
Changeset List

			Path	Packages
M			dataengines/applicationjobs/CMakeLists.txt (5 lines)
M			dataengines/applicationjobs/jobaction.h (17 lines)
M			dataengines/applicationjobs/jobaction.cpp (14 lines)
M			dataengines/applicationjobs/jobcontrol.h (8 lines)
M			dataengines/applicationjobs/jobcontrol.cpp (13 lines)
M			dataengines/applicationjobs/kuiserverengine.h (147 lines)
M			dataengines/applicationjobs/kuiserverengine.cpp (473 lines)

Status	Author	Revision
Closed	broulik	D20490 Rewrite notifications dataengine to work with libnotificationmanager
Closed	broulik	D20576 Add new notifications KCM
Closed	broulik	D20266 Add new notification plasmoid
Closed	broulik	D21061 [Task Manager] Use libnotificationmanager for notification badges and application job reporting
Closed	broulik	D20491 Rewrite applicationjobs dataengine to work with libnotificationmanager
Closed	broulik	D20265 Introduce libnotificationmanager
Closed	broulik	D20196 Add Notify capability to KConfigXT