Differential D20490

Rewrite notifications dataengine to work with libnotificationmanager
ClosedPublic
Actions

Authored by broulik on Apr 12 2019, 11:52 AM.

Details

Reviewers

Summary

Keeps it mostly working for compatibility.

The grouping stuff in there has been dropped, the old plasmoid should otherwise continue to work as normal.
The dataengine inhibition feature used by plasma-nm is defunct now, not sure how this could be implemented in the new system as the Server knows nothing about inhibitions, it's all filtered in the models.

Test Plan

Depends on D20265

Tried with old plasmoid, got notifications with title and text and images. Also tested the timer plasmoid and it successfully showed a "timer finished" notification with the new system

Diff Detail

Repository

R120 Plasma Workspace

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Apr 12 2019, 11:52 AM

Restricted Application added a project: Plasma. · View Herald TranscriptApr 12 2019, 11:52 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Apr 12 2019, 11:52 AM

broulik edited the test plan for this revision. (Show Details)

broulik added a dependency: D20265: Introduce libnotificationmanager.

mart accepted this revision.Apr 24 2019, 10:40 AM

This revision is now accepted and ready to land.Apr 24 2019, 10:40 AM

without the new plasmoid running shis actually doesn't work

This revision now requires changes to proceed.Apr 24 2019, 11:53 AM

mart added inline comments.Apr 24 2019, 12:22 PM

dataengines/notifications/notificationsengine.cpp
64	needs to call init() here and Server::self().init(); needs to be somewhere

broulik marked an inline comment as done.May 8 2019, 11:35 AM

All merged https://cgit.kde.org/plasma-workspace.git/commit/?id=3c52fc3bc05e0f351d4998ad54edae1a4e21a043

sitter accepted this revision.May 9 2019, 1:59 PM

sitter removed reviewers: Plasma, mart.

This revision is now accepted and ready to land.May 9 2019, 2:01 PM

sitter closed this revision.May 9 2019, 2:01 PM

Revision Contents
Changeset List

		Path
M		dataengines/notifications/CMakeLists.txt (22 lines)
M		dataengines/notifications/notificationaction.cpp (6 lines)
D	M	dataengines/notifications/notifications_test.cpp (87 lines)
D	M	dataengines/notifications/notificationsanitizer.h (42 lines)
D	M	dataengines/notifications/notificationsanitizer.cpp (107 lines)
M		dataengines/notifications/notificationsengine.h (39 lines)
M		dataengines/notifications/notificationsengine.cpp (409 lines)
D	M	dataengines/notifications/org.freedesktop.Notifications.xml (37 lines)

Status	Author	Revision
Closed	broulik	D20491 Rewrite applicationjobs dataengine to work with libnotificationmanager
Closed	broulik	D20576 Add new notifications KCM
Closed	broulik	D20266 Add new notification plasmoid
Closed	broulik	D21061 [Task Manager] Use libnotificationmanager for notification badges and application job reporting
Closed	broulik	D20490 Rewrite notifications dataengine to work with libnotificationmanager
Closed	broulik	D20265 Introduce libnotificationmanager
Closed	broulik	D20196 Add Notify capability to KConfigXT