Rewrite notifications dataengine to work with libnotificationmanager

Authored by broulik on Apr 12 2019, 11:52 AM.



Keeps it mostly working for compatibility.

The grouping stuff in there has been dropped, the old plasmoid should otherwise continue to work as normal.
The dataengine inhibition feature used by plasma-nm is defunct now, not sure how this could be implemented in the new system as the Server knows nothing about inhibitions, it's all filtered in the models.

Test Plan

Depends on D20265

Tried with old plasmoid, got notifications with title and text and images. Also tested the timer plasmoid and it successfully showed a "timer finished" notification with the new system

Diff Detail

R120 Plasma Workspace
Lint Skipped
Unit Tests Skipped
broulik created this revision.Apr 12 2019, 11:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 12 2019, 11:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 12 2019, 11:52 AM
broulik edited the test plan for this revision. (Show Details)
mart accepted this revision.Apr 24 2019, 10:40 AM
This revision is now accepted and ready to land.Apr 24 2019, 10:40 AM
mart requested changes to this revision.Apr 24 2019, 11:53 AM

without the new plasmoid running shis actually doesn't work

This revision now requires changes to proceed.Apr 24 2019, 11:53 AM
mart added inline comments.Apr 24 2019, 12:22 PM

needs to call init() here
and Server::self().init(); needs to be somewhere

broulik marked an inline comment as done.May 8 2019, 11:35 AM
sitter accepted this revision.May 9 2019, 1:59 PM
sitter removed reviewers: Plasma, mart.
This revision is now accepted and ready to land.May 9 2019, 2:01 PM
sitter closed this revision.May 9 2019, 2:01 PM