Differential D20488

Fix build with poppler <0.58
ClosedPublic
Actions

Authored by heikobecker on Apr 12 2019, 11:31 AM.

Details

Reviewers

aacid

Commits

R223:e01329eb4760: Fix build with poppler <0.58

Summary

Poppler::FormFieldSignature::signatureType
Poppler::SignatureValidationInfo::hashAlgorithm
Poppler::SignatureValidationInfo::signature
Poppler::SignatureValidationInfo::signedRangeBounds
Poppler::SignatureValidationInfo::signerSubjectDN
Poppler::SignatureValidationInfo::signsTotalDocument

were all introduced with poppler 0.58.

Test Plan

Builds fine with poppler 0.57 and 0.75, looked at
http://tecxoft.com/samples/pdf_digital_signature_timestamp.pdf

Diff Detail

Repository

R223 Okular

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

heikobecker created this revision.Apr 12 2019, 11:31 AM

Restricted Application added a project: Okular. · View Herald TranscriptApr 12 2019, 11:31 AM

Restricted Application added a subscriber: okular-devel. · View Herald Transcript

heikobecker requested review of this revision.Apr 12 2019, 11:31 AM

Harbormaster completed remote builds in B10765: Diff 56055.Apr 12 2019, 11:31 AM

Awesome thanks.

Landing it in a bit

This revision is now accepted and ready to land.Apr 12 2019, 9:59 PM

Closed by commit R223:e01329eb4760: Fix build with poppler <0.58 (authored by heikobecker, committed by aacid). · Explain WhyApr 12 2019, 10:06 PM

This revision was automatically updated to reflect the committed changes.

Thanks for landing.

Not sure how common that poppler version still is, but do you think it's worth a respin for 19.04?

In D20488#449028, @heikobecker wrote:

Thanks for landing.

Not sure how common that poppler version still is, but do you think it's worth a respin for 19.04?

From looking here https://repology.org/project/poppler/badges there's only like two or three releases of distros that are >= 0.51 and < 0.58 so i don't really think it's a big deal. But if you disagree you can always email kde-distro-packagers@kde.org and give them a heads up.

Revision Contents
Changeset List

			Path	Packages
M			generators/poppler/CMakeLists.txt (9 lines)
M			generators/poppler/config-okular-poppler.h.cmake (3 lines)
M			generators/poppler/formfields.cpp (4 lines)
M			generators/poppler/pdfsignatureutils.cpp (20 lines)