Differential D20485

Add Q_PROPERTIES
ClosedPublic
Actions

Authored by vkrause on Apr 12 2019, 9:28 AM.

Details

Reviewers

Commits

Summary

This isn't 100% complete yet, but enough to become useful for the two
Grantlee formatters consuming these objects. It should also be useful
for QML consumers (therefore using variant containers rather than strictly
typed ones).

Diff Detail

Repository

R174 KContacts

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vkrause created this revision.Apr 12 2019, 9:28 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 12 2019, 9:28 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.Apr 12 2019, 9:28 AM

Harbormaster completed remote builds in B10762: Diff 56048.Apr 12 2019, 9:28 AM

Any objections to this one? It's blocking integration of the entire kcontact/grantlee patch series.

Oops sorry I missed this one.
Not problem for me.

This revision is now accepted and ready to land.Apr 16 2019, 11:55 AM

Thanks :)

Closed by commit R174:a0757af06537: Add Q_PROPERTIES (authored by vkrause). · Explain WhyApr 16 2019, 5:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			src/address.h (24 lines)
M			src/address.cpp (1 line)
M			src/addressee.h (53 lines)
M			src/addressee.cpp (32 lines)
M			src/email.h (10 lines)
M			src/geo.h (8 lines)
M			src/phonenumber.h (13 lines)
M			src/resourcelocatorurl.h (12 lines)
M			src/resourcelocatorurl.cpp (1 line)