Avoid indirection when inserting basic data
ClosedPublic

Authored by bruns on Apr 12 2019, 12:07 AM.

Details

Summary

When setFileItem() is called, m_fileItems.size() is always 1, for
setFileItems() there are always multiple elements, thus it is known which
branch of insertBasicData() will be taken. Just call the corresponding
target method directly, and remove the unused private insertBasicData().

Test Plan

ctest

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 12 2019, 12:07 AM
Restricted Application added a project: Baloo. · View Herald TranscriptApr 12 2019, 12:07 AM
bruns requested review of this revision.Apr 12 2019, 12:07 AM
This revision is now accepted and ready to land.Apr 12 2019, 5:16 PM
This revision was automatically updated to reflect the committed changes.