[balooctl] Cleanup handling of different positional arguments
ClosedPublic

Authored by bruns on Apr 11 2019, 12:59 AM.

Details

Summary

Remove the temporary Url list, and remove the disambiguities:

  1. An existing files named "file:..." or "inode:..." was handled as documentID/inode in the loop.
  2. An inode number matching an existing file name was interpreted as file name, even when the "-i" option was specified.

Also, parsing errors of inode/documentId numbers where ignored, stating
"No index information found" instead.

Add the currently processed Url to the error messages, to make it
more obvious which one the error refers to.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 11 2019, 12:59 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 11 2019, 12:59 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 11 2019, 12:59 AM
ngraham accepted this revision.Apr 11 2019, 5:28 PM
This revision is now accepted and ready to land.Apr 11 2019, 5:28 PM
This revision was automatically updated to reflect the committed changes.