Clear terminal display when closing and opening it
Needs RevisionPublic

Authored by khanaasif on Apr 10 2019, 8:48 PM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Summary

In this diff, the function definition of sendCdToTerminal is changed to run just a clear command after the cd command.

BUG: 393737

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
khanaasif created this revision.Apr 10 2019, 8:48 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptApr 10 2019, 8:48 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
khanaasif requested review of this revision.Apr 10 2019, 8:48 PM
ngraham retitled this revision from An attempt to fix Bug 393737 - Clear terminal display when closing and opening it. to Clear terminal display when closing and opening it. .Apr 11 2019, 5:30 PM
ngraham edited the summary of this revision. (Show Details)
ngraham retitled this revision from Clear terminal display when closing and opening it. to Clear terminal display when closing and opening it.Apr 11 2019, 5:42 PM
ngraham accepted this revision.Apr 11 2019, 5:45 PM

This seems like a reasonable compromise to me. Clearing the output when the panel is closed and re-opened keeps it visually clean and I think it makes sense. @elvisangelaccio?

Also @khanaasif please provide your email address so if this patch is accepted by Dolphin's maintainer, we can land it with correct authorship information. Thanks!

This revision is now accepted and ready to land.Apr 11 2019, 5:45 PM

@ngraham thanks for the revision. My email address is aasifk106@gmail.com

elvisangelaccio requested changes to this revision.Apr 11 2019, 9:45 PM

Hmm, I don't I like it sorry. Running clear without the user permission could be annoying or even dangerous.

This seems like a reasonable compromise to me. Clearing the output when the panel is closed and re-opened keeps it visually clean and I think it makes sense.

But this is not what this patch does. clear will be executed every time you change a folder in dolphin.

This revision now requires changes to proceed.Apr 11 2019, 9:45 PM
meven added a subscriber: meven.Apr 12 2019, 6:55 AM

Hmm, I don't I like it sorry. Running clear without the user permission could be annoying or even dangerous.

I would suggest to instead of clearing the terminal, scrolling down. It would be feature-wise equivalent and would keep the history at hand.

Nice feature idea.

alexde added a subscriber: alexde.Apr 12 2019, 11:33 AM

This patch looks more like a workaround to me. I'd suggest to identify the root cause of "^C" and "cd <path>" whenever the terminal is hidden and reopened again by hitting F4 and to find a another solution as I guess and especially hope that this behaviour is actually not necessary to happen.

This patch looks more like a workaround to me. I'd suggest to identify the root cause of "^C" and "cd <path>" whenever the terminal is hidden and reopened again by hitting F4 and to find a another solution as I guess and especially hope that this behaviour is actually not necessary to happen.

It is needed to prevent data loss: https://bugs.kde.org/show_bug.cgi?id=161637

The proper solution would be to extend the KonsolePart API to allow clearing the previous input.