Differential D20434

KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator
ClosedPublic
Actions

Authored by loh.tar on Apr 10 2019, 2:02 PM.

Details

Reviewers
cullmann
dhaumann
Group Reviewers
KTextEditor
Commits
R39:c95655f845da: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator
Summary

The old special created pixmap is once working fine but not so easy to maintain.
The look is/was however special too.

Test Plan

New look, the old you will know

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Apr 10 2019, 2:02 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptApr 10 2019, 2:02 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Apr 10 2019, 2:02 PM
ngraham added a subscriber: ngraham.Apr 10 2019, 2:49 PM

+1, this seems appropriate.

cfeck added a subscriber: cfeck.Apr 10 2019, 7:25 PM

The proposed character is in Unicode since version 1.1 (1993).

dhaumann accepted this revision.Apr 10 2019, 9:03 PM
dhaumann added a subscriber: dhaumann.

Let's give this a try.

This revision is now accepted and ready to land.Apr 10 2019, 9:03 PM
cullmann requested changes to this revision.Apr 10 2019, 9:44 PM

I think to not agonize MSVC it would be better to use the unicode code point for the QChar constructor.
After that is altered I think, too, this should go in, nice!

This revision now requires changes to proceed.Apr 10 2019, 9:44 PM
loh.tar updated this revision to Diff 55955.Apr 11 2019, 3:21 AM
loh.tar edited the summary of this revision. (Show Details)
  • Use unicode code point QChar constructor
  • Due to comment by @cfeck remove fallback/config hint and...
  • Init in header as const
  • Add hint about different char sizes
cullmann accepted this revision.Apr 11 2019, 5:34 AM

Thanks

This revision is now accepted and ready to land.Apr 11 2019, 5:34 AM
Closed by commit R39:c95655f845da: KateIconBorder: Use UTF-8 char instead of special pixmap as dyn wrap indicator (authored by loh.tar). · Explain WhyApr 11 2019, 12:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55955

View Options

src/view/kateviewhelpers.h

Loading...
View Options

src/view/kateviewhelpers.cpp

Loading...