Don't include fftw's and exiv2's headers with -isystem
ClosedPublic

Authored by heikobecker on Jun 28 2016, 10:31 PM.

Details

Summary

39e6822a01c823b74a5b1b9e75c9737a1f79049e introduced this to avoid
warnings from third party code. But it broke the build with gcc6
because fftw and exiv2 return the default include directory via the
respective *_INCLUDE_DIRs on my system. There's an gcc bug report
closed as "WONTFIX" about this issue [1], which recommends not to
use -isystem with default include directories.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129.

Test Plan

Builds fine with gcc6.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker retitled this revision from to Don't include fftw's and exiv2's headers with -isystem.
heikobecker updated this object.
heikobecker edited the test plan for this revision. (Show Details)
heikobecker added a reviewer: Krita.
rempt accepted this revision.Jul 2 2016, 9:34 AM
rempt added a reviewer: rempt.
rempt added a subscriber: rempt.

Works on Linux for me, but I haven't tested with mingw or clang yet. I doubt it'll make a difference, though, since it worked before the 39e6822a01c823b74a5b1b9e75c9737a1f79049e patch on those platforms.

This revision is now accepted and ready to land.Jul 2 2016, 9:34 AM
This revision was automatically updated to reflect the committed changes.