add apt overlays to prevent running 'upgrade' on neon systems
AbandonedPublic

Authored by sitter on Apr 10 2019, 10:34 AM.

Details

Summary

upgrade is not suitable for neon because we carry out transitions all the
time. the overlay prevents running upgrade altogether, instead opting to
educate the user.

the upgrade will run all the same if -y is passed so as to prevent things
falling apart for scripts and the like (which are all expected to pass -y
or they are doing it wrong one would think)

since the overlay is is in sbin this always overrides the regular apts
(given a suitable PATH setup, which is the case by default). calling
apt by absolute path in usr/bin/ also bypasses the overlay (again,
something a well-behaved script should probably do)

https://phabricator.kde.org/T3633

Diff Detail

Branch
apt-overlay
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10731
Build 10749: arc lint + arc unit
sitter requested review of this revision.Apr 10 2019, 10:34 AM
sitter created this revision.
sitter updated this revision to Diff 55977.Apr 11 2019, 9:16 AM

drop argv duping. it's not necessary

apt-get dist-upgrade

Traceback (most recent call last):

1: from /usr/sbin/apt-overlay:37:in `<main>'

/usr/sbin/apt-overlay:37:in `exec': No such file or directory - /usr/bin/apt-overlay (Errno::ENOENT

shouldn't /usr/sbin/apt and /usr/sbin/apt-get do something to pass the arguments along?

Approved on telegram by Jon. Turns out the problems were something gone wrong with patching. Overlay landing in unstable for preliminary testing

sitter abandoned this revision.Apr 23 2019, 12:11 PM