separe mobile text selection to avoid recursive imports
ClosedPublic

Authored by mart on Apr 10 2019, 9:31 AM.

Details

Summary

the mobile text selection toolbar uses toolbuttons, which in turn use the
private import. This will make the components loading stuck in dependency
resolution

Test Plan

all loads correctly now

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Apr 10 2019, 9:31 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 10 2019, 9:31 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Apr 10 2019, 9:31 AM
hein accepted this revision.Apr 10 2019, 11:29 AM
hein added a subscriber: hein.

Works here now, thx!

This revision is now accepted and ready to land.Apr 10 2019, 11:29 AM
This revision was automatically updated to reflect the committed changes.
broulik added inline comments.
src/declarativeimports/plasmacomponents3/ComboBox.qml
174

Does this not need to be adjusted? ComboBox is broken here.