Do not mention "Set as Wallpaper" in credits because this feature has been removed
ClosedPublic

Authored by aspotashev on Apr 9 2019, 10:42 PM.

Diff Detail

Repository
R463 KPhotoAlbum
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aspotashev requested review of this revision.Apr 9 2019, 10:42 PM
aspotashev created this revision.

I guess we'll need to review the whole author/credits section anyway - there are more issues here:

  • Robert is mentioned twice (as author and credit)
  • the experimental SQL backend has been removed
  • there are ~65 people who committed to the repo, but only 10 author and 11 credits

I'm afraid nobody will spend their time reviewing all the 65 committers' contributions because this kind of task is not rewarding and sounds like a waste of time. Thus this patch may stay on hold forever unless we push it without total review of contributors list.

I made this patch just to facilitate translators' work: it's hard to confidently translate something that is missing from the actual application UI.

johanneszarl accepted this revision.Apr 22 2019, 7:58 PM

I made this patch just to facilitate translators' work: it's hard to confidently translate something that is missing from the actual application UI.

Thanks for the context - this makes it easy to accept...

This revision is now accepted and ready to land.Apr 22 2019, 7:58 PM