Improve handling of clashing country name strings
ClosedPublic

Authored by vkrause on Apr 9 2019, 5:34 PM.

Details

Summary

This now no longer removes name clashes within one language by using a
hash (and yes, those cases do seem to exist), and it propagates the
language information all the way to the error message to make it easier
to investigate those issues.

This is mainly a preparation for applying more aggressive string
normalization on the country names, which we can do as along is it
doesn't increase the amount of ambiguities here.

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 9 2019, 5:34 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 9 2019, 5:34 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 9 2019, 5:34 PM
dvratil accepted this revision.Apr 11 2019, 12:32 PM
This revision is now accepted and ready to land.Apr 11 2019, 12:32 PM
This revision was automatically updated to reflect the committed changes.