Differential D20412

Display metadata information in case only basic indexing is enabled
ClosedPublic
Actions

Authored by astippich on Apr 9 2019, 4:23 PM.

Details

Reviewers

bruns
ngraham

Commits

R824:22ea087cec1a: Display metadata information in case only basic indexing is enabled

Summary

Metadata was only extracted manually when the indexing was disabled
completely. In case of basic indexing, also no metadata is available,
hence also extract it then.

Test Plan

Enable basic file indexing only (and make sure to delete old database)
Metadata for files is shown in Information Panel/Tooltips

Diff Detail

Repository

R824 Baloo Widgets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich created this revision.Apr 9 2019, 4:23 PM

Restricted Application added a project: Baloo. · View Herald TranscriptApr 9 2019, 4:23 PM

Restricted Application added a subscriber: Baloo. · View Herald Transcript

astippich requested review of this revision.Apr 9 2019, 4:23 PM

Harbormaster completed remote builds in B10667: Diff 55834.Apr 9 2019, 4:23 PM

Ah, very nice catch.

This revision is now accepted and ready to land.Apr 9 2019, 5:17 PM

I wonder if it wouldn't be better to check if baloo returned any data - it may have started indexing, but is still working on it.

src/filemetadataprovider.cpp
318	you can remove the `m_config.fileIndexingEnable() &&`, as it evaluates to true here always - if it is false, the first checks is true.

This revision now requires changes to proceed.Apr 9 2019, 5:23 PM

remove superfluous check

Harbormaster completed remote builds in B10673: Diff 55847.Apr 9 2019, 5:59 PM

astippich marked an inline comment as done.Apr 9 2019, 5:59 PM

astippich added inline comments.

src/filemetadataprovider.cpp
318	true :)

bruns accepted this revision.Apr 9 2019, 7:30 PM

This revision is now accepted and ready to land.Apr 9 2019, 7:30 PM

Closed by commit R824:22ea087cec1a: Display metadata information in case only basic indexing is enabled (authored by astippich). · Explain WhyApr 10 2019, 5:24 PM

This revision was automatically updated to reflect the committed changes.

astippich marked an inline comment as done.

Revision Contents
Changeset List

			Path	Packages
M			src/filemetadataprovider.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	55834	aa7179b		Apr 9 2019, 4:23 PM	★	★
Diff 2	55847	aa7179b	- remove superfluous check	Apr 9 2019, 5:59 PM	★	★
Diff 3	55925	170a52b	R824:22ea087cec1a871ce6a12b2a3aef37efb8dcc7b1	Apr 10 2019, 5:24 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
e5c03f4ce955	b4c62debeae3	dde67dc0623c	Alexander Stippich	remove superfluous check	Apr 9 2019, 5:57 PM
dde67dc0623c	10f291405b0f	aa7179b634f5	Alexander Stippich	Display metadata information in case only basic indexing is enabled (Show More…)	Apr 8 2019, 6:10 AM

Diff 55925

View Options

src/filemetadataprovider.cpp