Make preview(dashed rectangle) of rectangle annotation colorful
Needs RevisionPublic

Authored by ahmedbilal on Apr 9 2019, 1:01 PM.

Details

Summary

Diff Detail

Repository
R223 Okular
Branch
make_preview_rect_colorful
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10659
Build 10677: arc lint + arc unit
ahmedbilal created this revision.Apr 9 2019, 1:01 PM
Restricted Application added a project: Okular. · View Herald TranscriptApr 9 2019, 1:01 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
ahmedbilal requested review of this revision.Apr 9 2019, 1:01 PM
Restricted Application removed a subscriber: Okular. · View Herald TranscriptApr 9 2019, 1:02 PM
ahmedbilal edited the summary of this revision. (Show Details)Apr 9 2019, 1:05 PM
ahmedbilal added a reviewer: sander.

@sander I have added you as reviewer and subscriber.

ngraham accepted this revision.Apr 9 2019, 3:07 PM
ngraham added a subscriber: ngraham.

I think this is fine.

This revision is now accepted and ready to land.Apr 9 2019, 3:07 PM
ahmedbilal added a reviewer: sander.
aacid requested changes to this revision.Apr 21 2019, 11:26 PM
aacid added a subscriber: aacid.

This is bad.

It changes the rendering of i(preview) nline notes to something that is not resembling at all how they will look, i.e. here it draws a non filled rectangle with a yellow border when they end up like a yellow rectangle with a black border once finished.

This revision now requires changes to proceed.Apr 21 2019, 11:26 PM