Add 'open' button so users doesn't need to choose only with double-click and also allow to
open app with enter
New dialog:
Details
Details
- Reviewers
- None
- Group Reviewers
Plasma - Commits
- R838:5ddeff154725: AppChooserDialog: make it more usable
Diff Detail
Diff Detail
- Repository
- R838 Flatpak Support: KDE Portal for XDG Desktop
- Branch
- Plasma/5.15
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10653 Build 10671: arc lint + arc unit
Comment Actions
IMO this should be a single-click UI, with no Open button: since there's nothing useful you can do with a selected item besides opening it, it should always open with a single-click.
Comment Actions
No. The rule is that following that setting only makes sense for items that have a real selection state, i.e. you can do something other than opening it when it's selected. If you can't, then it's a button and it should always activate on single-click. This is why toolbar buttons always activate on a single-click even when you have double-click mode activated.
Comment Actions
What Nate says makes sense to me. Single click should be fine, there's no real value in just selecting it.
Don't we already have another dialog for choosing applications? It could make sense to use the same everywhere and improve it once.
i.e. KOpenWithDialog from KIO::Widgets
Comment Actions
+1 for unifying, and I'll admit that I kind of like this one better than the other one which is really complicated and fiddly. With an added search/filter field, this one would be just right.
Comment Actions
Uppps, I accidentaly pushed the change instead running "arc diff". I made it to select app with just a single click as you wanted to, without buttons below.
I'm not sure this will be easy to replace with KOpenWithDialog() as we receive from the portal just list of applications we should present, it's not us who constructs the list of applications which is what the KOpenWithDialog() does if I'm not mistaken.