Differential D20399

[Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right
ClosedPublic
Actions

Authored by ndavis on Apr 9 2019, 4:27 AM.

Details

Reviewers
filipf
ngraham
Group Reviewers
VDG
Plasma
Commits
R119:e09cc99b5250: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right
Summary

I meant to do this in D19874, but I must have accidentally reset the change.

Test Plan

Looks exactly the same as the screenshots in D19874, which were made with this change

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Apr 9 2019, 4:27 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 9 2019, 4:27 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Apr 9 2019, 4:27 AM
ndavis retitled this revision from [Kickoff] Anchor subtitle in KickoffItem to arrow.right to [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right.Apr 9 2019, 4:28 AM
filipf accepted this revision.Apr 9 2019, 12:09 PM
filipf added a subscriber: filipf.

Works as desired and is more efficient than anchoring to parent.right and then adding symmetrical units.smallSpacing * 6 right margin (since that's how the arrow is already anchored).

This revision is now accepted and ready to land.Apr 9 2019, 12:09 PM
ngraham accepted this revision.Apr 9 2019, 3:09 PM
Closed by commit R119:e09cc99b5250: [Kickoff] Anchor right of subTitleElement in KickoffItem to arrow.right (authored by ndavis). · Explain WhyApr 9 2019, 5:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55839

View Options

applets/kickoff/package/contents/ui/KickoffItem.qml

Loading...