Remove warning: do not use 'else' after 'return'
ClosedPublic

Authored by andreagenor on Apr 9 2019, 1:22 AM.

Details

Summary

Signed-off-by: André Agenor <andreagenor@icloud.com>

Diff Detail

Repository
R374 KolourPaint
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
andreagenor requested review of this revision.Apr 9 2019, 1:22 AM
andreagenor created this revision.
pino added a subscriber: pino.Apr 9 2019, 4:51 AM

Which warnings do the two function trigger?
Also, adding { ... } breaks the code style.

andreagenor updated this revision to Diff 55821.Apr 9 2019, 2:13 PM
  • Fix code style
In D20398#446407, @pino wrote:

Which warnings do the two function trigger?
Also, adding { ... } breaks the code style.

This two warnings below
https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html

Sorry about code style, I tend to automate with clang format and I forgot the actual code style

we don't have a clangformat file specified for kde projects, maybe this is
something good to add. I voted for global .editoconfigfiles but I was
outvoted. :)

tcanabrava accepted this revision.Mon, May 6, 12:20 PM
This revision is now accepted and ready to land.Mon, May 6, 12:20 PM
This revision was automatically updated to reflect the committed changes.