Ctrl-Tab should work in "split-only" view as well
ClosedPublic

Authored by thsurrel on Apr 8 2019, 8:58 PM.

Details

Summary

The Ctrl-Tab and Ctrl-Shift-Tab were working only when multiple
tabs were opened, but it should work as well when only one tab
is opened but multiple splits are created within that tab.

Test Plan

Open konsole with a single tab, then create several splits.
Use Ctrl-Tab and Ctrl-Shift-Tab to navigate between the splits
in chronological order.

Diff Detail

Repository
R319 Konsole
Branch
arc_ctrl_tab
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10640
Build 10658: arc lint + arc unit
thsurrel created this revision.Apr 8 2019, 8:58 PM
Restricted Application added a project: Konsole. · View Herald TranscriptApr 8 2019, 8:58 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
thsurrel requested review of this revision.Apr 8 2019, 8:58 PM

When we have multiple tabs / splits this is not confusing?

It will go through all views, whether they are in a dedicated tab or in splits. This is what I would personally find the most useful.

I'm fine with this. Tomaz, any objection?

None, I’m ok with it

Em qua, 17 de abr de 2019 às 15:04, Kurt Hindenburg <
noreply@phabricator.kde.org> escreveu:

hindenburg added a comment. View Revision
https://phabricator.kde.org/D20395

I'm fine with this. Tomaz, any objection?

*REPOSITORY*
R319 Konsole

*REVISION DETAIL*
https://phabricator.kde.org/D20395

*To: *thsurrel, Konsole, hindenburg, tcanabrava
*Cc: *konsole-devel, gennad, thsurrel, ngraham, maximilianocuria,
hindenburg

hindenburg accepted this revision.Apr 17 2019, 2:24 PM
This revision is now accepted and ready to land.Apr 17 2019, 2:24 PM
This revision was automatically updated to reflect the committed changes.