Make KNS applications act more like applications
ClosedPublic

Authored by leinir on Apr 8 2019, 12:40 PM.

Details

Summary

This patch adds functionality to allow the KNS backend to report applications in a more familiar fashion: If the specific backend has applications, the run button will read Launch (rather than Use), and only be shown if there are downloaded (installed) executables to run, and then run that when activated.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Apr 8 2019, 12:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2019, 12:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Apr 8 2019, 12:40 PM
apol added inline comments.Apr 8 2019, 1:16 PM
libdiscover/backends/KNSBackend/KNSResource.cpp
213

Can't we do this in the adoption command? This way we won't have another special case.

leinir planned changes to this revision.Apr 9 2019, 7:42 AM
leinir marked an inline comment as done.
leinir added inline comments.
libdiscover/backends/KNSBackend/KNSResource.cpp
213

Hmm... I guess we could... It requires making a choice in the knsrc file on which tool to use for using the app, which i guess might be e.g. AppImageLauncher... but i guess that isn't really that much of a problem anyway. Sure, i'll just do that instead. And yes, less special cases are certainly nice :)

leinir updated this revision to Diff 55802.Apr 9 2019, 7:50 AM
leinir marked an inline comment as done.

We now assume that an AdoptionCommand is set. This reduces the code overhead, which is always nice.

apol accepted this revision.Apr 9 2019, 8:31 PM
This revision is now accepted and ready to land.Apr 9 2019, 8:31 PM
This revision was automatically updated to reflect the committed changes.