Differential D20370

[Folder View] Implement a user-configurable setting for label width
ClosedPublic
Actions

Authored by ngraham on Apr 8 2019, 12:55 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
VDG
Commits
R119:bad5d2b8973c: [Folder View] Implement a user-configurable setting for label width
Summary

It seems impossible to satisfy everyone's preferences regarding label width in Folder
View. Some people want small icons with narrow labels (403412). Other people want small
icons with wide labels (379432). There have been other complaints in the past too, which
have led to the current settings, but because these preferences are opposed, the more we
tweak the settings to please one group of people, the more we annoy another.

Accordingly, This patch implements a user-configurable setting to determine the label width
for Folder View items in Icons view. This should put the matter to rest once and for all.

FEATURE: 403094
FIXED-IN: 5.16

Test Plan

Default settings (large icons + medium label width):

Small icons + narrow labels:

Small icons + medium labels:

SmallMedium icons + medium labels:

Large icons + wide labels:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 8 2019, 12:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 8 2019, 12:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 8 2019, 12:55 AM
ngraham edited the test plan for this revision. (Show Details)Apr 8 2019, 12:57 AM
broulik added a subscriber: broulik.Apr 8 2019, 2:57 PM
broulik added inline comments.
containments/desktop/package/contents/ui/ConfigIcons.qml
266

You can just use a JavaScript Array:

model: [
    i18n("Narrow"),
    i18n("Medium"),
    i18n("Wide")
]

This way you can also use i18n for translation

ngraham updated this revision to Diff 55749.Apr 8 2019, 3:31 PM

Rebase on master, use a JavaScript array, localize text

ngraham marked an inline comment as done.Apr 8 2019, 3:31 PM
hein accepted this revision.Apr 8 2019, 3:50 PM
This revision is now accepted and ready to land.Apr 8 2019, 3:50 PM
Closed by commit R119:bad5d2b8973c: [Folder View] Implement a user-configurable setting for label width (authored by ngraham). · Explain WhyApr 8 2019, 4:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55752

View Options

containments/desktop/package/contents/config/main.xml

Loading...
View Options

containments/desktop/package/contents/ui/ConfigIcons.qml

Loading...
View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...