Differential D20364

Dont add default valued date filters to json
ClosedPublic
Actions

Authored by bruns on Apr 7 2019, 6:29 PM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Baloo
Frameworks
Commits
R293:ff630d96ec78: Dont add default valued date filters to json
Summary

Commit 41d5013e5b7c ("SearchStore: Implement date filter queries") changed
the initialization/default filter from -1 to 0. Now, the
day/month/year filters are always added to the json data, although not
having any effect.

Test Plan

run dolphin, select e.g. "Images"
yearFilter/monthFilter/dayFilter no longer appear in json'ed query

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 7 2019, 6:29 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 7 2019, 6:29 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 7 2019, 6:29 PM
astippich accepted this revision.Apr 7 2019, 6:52 PM
This revision is now accepted and ready to land.Apr 7 2019, 6:52 PM
Closed by commit R293:ff630d96ec78: Dont add default valued date filters to json (authored by bruns). · Explain WhyApr 7 2019, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/query.cpp (6 lines)

Diff 55706

View Options

src/lib/query.cpp

Loading...