Differential D20361

[tagsaction] Don't crash on multiple files
ClosedPublic
Actions

Authored by nicolasfella on Apr 7 2019, 4:32 PM.

Details

Reviewers
elvisangelaccio
Commits
R824:96505aed6d59: [tagsaction] Don't crash on multiple files
Summary

Tagging multiple files is not supported and thus we never create m_metadata for it. However, we start the tags listing and as soon as tags are found m_metadata is accesses which results in a crash.

This patch delays the tags listing until m_metadata has been initialized

BUG: 401733

Test Plan

Select multiple files in Dolphin, right click -> no crash

Diff Detail

Repository
R824 Baloo Widgets
Branch
dontcrash
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10589
Build 10607: arc lint + arc unit
nicolasfella created this revision.Apr 7 2019, 4:32 PM
Restricted Application added a project: Baloo. · View Herald TranscriptApr 7 2019, 4:32 PM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
nicolasfella requested review of this revision.Apr 7 2019, 4:32 PM
nicolasfella edited the summary of this revision. (Show Details)Apr 7 2019, 4:33 PM
nicolasfella added a reviewer: elvisangelaccio.
elvisangelaccio accepted this revision.Apr 7 2019, 5:07 PM

Thanks. Please push to Applications/19.04

This revision is now accepted and ready to land.Apr 7 2019, 5:07 PM
Closed by commit R824:96505aed6d59: [tagsaction] Don't crash on multiple files (authored by nicolasfella). · Explain WhyApr 7 2019, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55693

View Options

src/tagsfileitemactionplugin/tagsfileitemaction.cpp

Loading...