Fix dialing via KDE Connect, and make it the default
ClosedPublic

Authored by vkrause on Apr 7 2019, 2:02 PM.

Details

Summary

Let's rather promote our own stuff rather than proprietary alternatives.
Same should be done for the SMS case, but so far I failed to make that
work properly (ie. with content) with KDE Connect.

Diff Detail

Repository
R459 Akonadi Contacts
Branch
arcpatch-D20353
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10631
Build 10649: arc lint + arc unit
vkrause created this revision.Apr 7 2019, 2:02 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 7 2019, 2:02 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 7 2019, 2:02 PM
dvratil accepted this revision.Apr 7 2019, 3:44 PM
dvratil added a subscriber: dvratil.

Haven't tried it, but looks sensible.

This revision is now accepted and ready to land.Apr 7 2019, 3:44 PM
mlaurent added inline comments.
src/akonadi-contacts/CMakeLists.txt
30

What about UseKdeConnectSms for sms ?

I thought about another approach I'd like to try before landing this, basically replacing explicit KDE Connect support with "System Default" which just let's the system handle tel: URLs directly. This is what KMail does and it has the advantage of being consistent everywhere, requiring less code and configuration, and actually supporting more Voip clients than we do here (Zoiper apparently works with KMail that way). And by default this also uses KDE Connect.

src/akonadi-contacts/CMakeLists.txt
30

I'll touch SMS separately, once I have figured out to actually make it work, but of course we should default to KDE Connect as well there.

vkrause updated this revision to Diff 55768.Apr 8 2019, 6:54 PM

Rework dialing via KDE Connect, and make that the default

Use the system-wide tel: URL handling, which is what KMail uses for this
too. KDE Connect works that way, as well as some other voip tools. It also
has the convenient side-effect that it's less work for us. Ideally the
others dialer apps listed here would support the same mechanism.

This revision was automatically updated to reflect the committed changes.