Differential D20346

Remove Collection references from Akonadi
ClosedPublic
Actions

Authored by dvratil on Apr 7 2019, 12:41 PM.

Tags

Subscribers

Details

Reviewers

vkrause
dfaure

Commits

R165:384ab29108d1: Remove Collection references from Akonadi

Summary

This was only used in one single place in KOrganizer, which we
removed as well.

Test Plan

All tests pass, KDE PIM still compilers

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dvratil created this revision.Apr 7 2019, 12:41 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 7 2019, 12:41 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dvratil requested review of this revision.Apr 7 2019, 12:41 PM

Harbormaster completed remote builds in B10572: Diff 55659.Apr 7 2019, 12:41 PM

dvratil added reviewers: vkrause, dfaure.Apr 7 2019, 1:13 PM

dfaure added inline comments.Apr 7 2019, 1:32 PM

src/server/notificationsubscriber.cpp
508	The old comment had the word "monitored" here, which got removed - on purpose, or by accident?

dvratil added inline comments.Apr 7 2019, 1:45 PM

src/server/notificationsubscriber.cpp
508	This logic does not concern itself with "monitored" state, that is handled outside of this if, below.

dfaure accepted this revision.Apr 7 2019, 1:48 PM

This revision is now accepted and ready to land.Apr 7 2019, 1:48 PM

This patch seems incomplete BTW.

collectionscheduler.cpp still uses Collection::referencedFullColumnName()

Hi Dan, can you push this ASAP? My own work keeps touching lines that have referenced() in them, a good recipe for merge conflicts for either of us at some point.

Remove last references to referencing.

Harbormaster completed remote builds in B10893: Diff 56280.Apr 15 2019, 7:59 AM

Nice pun :-)

Closed by commit R165:384ab29108d1: Remove Collection references from Akonadi (authored by dvratil). · Explain WhyApr 15 2019, 8:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/libs/CMakeLists.txt (1 line)
M			autotests/libs/collectionjobtest.h (1 line)
M			autotests/libs/collectionjobtest.cpp (50 lines)
M			autotests/libs/etmpopulationtest.cpp (74 lines)
D	M		autotests/libs/referencetest.h (34 lines)
D	M		autotests/libs/referencetest.cpp (238 lines)
M			autotests/server/CMakeLists.txt (1 line)
D	M		autotests/server/collectionreferencetest.cpp (264 lines)
M			autotests/server/dbinitializer.cpp (1 line)
M			src/agentbase/resourcebase.cpp (2 lines)
M			src/core/changerecorderjournal.cpp (5 lines)
M			src/core/collection.h (18 lines)
M			src/core/collection.cpp (13 lines)
M			src/core/collection_p.h (7 lines)
M			src/core/jobs/collectionmodifyjob.cpp (3 lines)
M			src/core/models/entitytreemodel.h (9 lines)
M			src/core/models/entitytreemodel.cpp (9 lines)
M			src/core/models/entitytreemodel_p.cpp (2 lines)
M			src/core/protocolhelper.cpp (1 line)
M			src/private/protocol.xml (7 lines)
M			src/private/protocol_p.h (1 line)
M			src/server/CMakeLists.txt (1 line)
M			src/server/akonadi.cpp (5 lines)
D	M		src/server/collectionreferencemanager.h (55 lines)
D	M		src/server/collectionreferencemanager.cpp (114 lines)
M			src/server/collectionscheduler.cpp (1 line)
M			src/server/connection.h (3 lines)
M			src/server/connection.cpp (7 lines)
M			src/server/handler/collectionfetchhandler.cpp (36 lines)
M			src/server/handler/collectionmodifyhandler.cpp (19 lines)
M			src/server/handlerhelper.h (1 line)
M			src/server/handlerhelper.cpp (4 lines)
M			src/server/notificationsubscriber.cpp (58 lines)
M			src/server/preprocessormanager.cpp (6 lines)
M			src/server/storage/akonadidb.xml (3 lines)
M			src/server/storage/notificationcollector.cpp (4 lines)

Diff 56284

autotests/libs/CMakeLists.txt

Loading...

autotests/libs/collectionjobtest.h

Loading...

autotests/libs/collectionjobtest.cpp

Loading...

autotests/libs/etmpopulationtest.cpp

Loading...

autotests/libs/referencetest.h

Loading...

autotests/libs/referencetest.cpp

Loading...

autotests/server/CMakeLists.txt

Loading...

autotests/server/collectionreferencetest.cpp

Loading...

autotests/server/dbinitializer.cpp

Loading...

src/agentbase/resourcebase.cpp

Loading...

src/core/changerecorderjournal.cpp

Loading...

src/core/collection.h

Loading...

src/core/collection.cpp

Loading...

src/core/collection_p.h

Loading...

src/core/jobs/collectionmodifyjob.cpp

Loading...

src/core/models/entitytreemodel.h

Loading...

src/core/models/entitytreemodel.cpp

Loading...

src/core/models/entitytreemodel_p.cpp

Loading...

src/core/protocolhelper.cpp

Loading...

src/private/protocol.xml

Loading...

src/private/protocol_p.h

Loading...

src/server/CMakeLists.txt

Loading...

src/server/akonadi.cpp

Loading...

src/server/collectionreferencemanager.h

Loading...

src/server/collectionreferencemanager.cpp

Loading...

src/server/collectionscheduler.cpp

Loading...

src/server/connection.h

Loading...

src/server/connection.cpp

Loading...

src/server/handler/collectionfetchhandler.cpp

Loading...

src/server/handler/collectionmodifyhandler.cpp

Loading...

src/server/handlerhelper.h

Loading...

src/server/handlerhelper.cpp

Loading...

src/server/notificationsubscriber.cpp

Loading...

src/server/preprocessormanager.cpp

Loading...

src/server/storage/akonadidb.xml

Loading...

src/server/storage/notificationcollector.cpp

Loading...