Differential D20339

Remove the DataMatrix code, just the QR code is enough
ClosedPublic
Actions

Authored by vkrause on Apr 7 2019, 9:51 AM.

Details

Reviewers
dvratil
Commits
R204:9596d568324c: Remove the DataMatrix code, just the QR code is enough
Summary

QR codes are much more widely used (and therefore recognized) and are more
compact, so the DataMatrix one is just taking up more space and makes this
look ugly.

Diff Detail

Repository
R204 KAddressBook
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10561
Build 10579: arc lint + arc unit
vkrause created this revision.Apr 7 2019, 9:51 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 7 2019, 9:51 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 7 2019, 9:51 AM
dvratil added a subscriber: dvratil.Apr 7 2019, 10:18 AM

Shouldn't the code that generates the datamatrix data also removed? Or does that lives elsewhere?

vkrause added a comment.Apr 7 2019, 12:33 PM

Yep, that's in akonadi-contacts of course...

dvratil accepted this revision.Apr 7 2019, 12:41 PM
This revision is now accepted and ready to land.Apr 7 2019, 12:41 PM
Closed by commit R204:9596d568324c: Remove the DataMatrix code, just the QR code is enough (authored by vkrause). · Explain WhyApr 8 2019, 6:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55640

View Options

src/viewertemplates/contact_embedded.html

Loading...