Differential D20295

Port away from SortableList::removeSorted
ClosedPublic
Actions

Authored by vkrause on Apr 6 2019, 9:30 AM.

Details

Reviewers
dvratil
Commits
R172:16a11e240dfa: Port away from SortableList::removeSorted

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 6 2019, 9:30 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 6 2019, 9:30 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 6 2019, 9:30 AM
dvratil requested changes to this revision.Apr 6 2019, 10:22 AM
dvratil added a subscriber: dvratil.

This looks complex enough to deserve its own helper function as well.

This revision now requires changes to proceed.Apr 6 2019, 10:22 AM
vkrause updated this revision to Diff 55545.Apr 6 2019, 12:13 PM

Add helper function for the inplace set difference happening here.

dvratil accepted this revision.Apr 6 2019, 3:49 PM
This revision is now accepted and ready to land.Apr 6 2019, 3:49 PM
Closed by commit R172:16a11e240dfa: Port away from SortableList::removeSorted (authored by vkrause). · Explain WhyApr 6 2019, 4:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/recurrence.cpp (19 lines)
Msrc/recurrencehelper_p.h (12 lines)

Diff 55575

View Options

src/recurrence.cpp

Loading...
View Options

src/recurrencehelper_p.h

Loading...