Differential D20291

Add unittest for clearPayload. Unfortunately it passes :-)
ClosedPublic
Actions

Authored by dfaure on Apr 6 2019, 9:05 AM.

Details

Reviewers
dvratil
vkrause
Commits
R165:53d0fddd9c3d: Add unittest for clearPayload. Unfortunately it passes :-)
Summary

There's a bug. Somewhere. But not here.

Test Plan

ctest

Diff Detail

Repository
R165 Akonadi
Branch
clearPayload (branched from Applications/19.04)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10507
Build 10525: arc lint + arc unit
dfaure created this revision.Apr 6 2019, 9:05 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 6 2019, 9:05 AM
dfaure requested review of this revision.Apr 6 2019, 9:05 AM
dvratil requested changes to this revision.Apr 6 2019, 10:14 AM
dvratil added inline comments.
autotests/libs/invalidatecachejobtest.cpp
50

There's synchronous collectionIdFromPath() in test_utils.h that does this already.

79

Use isEmpty() instead.

This revision now requires changes to proceed.Apr 6 2019, 10:14 AM
dfaure marked an inline comment as done.Apr 6 2019, 11:00 AM
dfaure added inline comments.
autotests/libs/invalidatecachejobtest.cpp
79

OK, but then the actual content isn't shown, on error.

dfaure updated this revision to Diff 55538.Apr 6 2019, 11:05 AM

as requested

dvratil accepted this revision.Apr 6 2019, 12:25 PM
This revision is now accepted and ready to land.Apr 6 2019, 12:25 PM
dfaure closed this revision.Apr 6 2019, 12:35 PM

Revision Contents
Changeset List

Diff 55538

View Options

autotests/libs/CMakeLists.txt

Loading...
View Options

autotests/libs/invalidatecachejobtest.cpp

Loading...