Differential D2028

Paint the software cursor directly in SceneQPainter
ClosedPublic
Actions

Authored by graesslin on Jun 28 2016, 8:39 AM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:758d41d6bfa5: Paint the software cursor directly in SceneQPainter

Summary

No need to delegate the painting of the software cursor into the backend.
The core has enough information to perform the rendering itself.

This change means less code duplication and all platforms which might use
a software cursor in QPainter compositor gain support for it without any
further adjustments.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 4787.Jun 28 2016, 8:39 AM

graesslin retitled this revision from to Paint the software cursor directly in SceneQPainter.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJun 28 2016, 8:39 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependency: D2027: Render cursor in multi-screen setup in QPainter Compositor.Jun 28 2016, 8:39 AM

sebas accepted this revision.Jun 28 2016, 3:35 PM

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Jun 28 2016, 3:35 PM

Closed by commit R108:758d41d6bfa5: Paint the software cursor directly in SceneQPainter (authored by graesslin). · Explain WhyJun 29 2016, 6:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/fbdev/scene_qpainter_fb_backend.h (1 line)
M			plugins/platforms/fbdev/scene_qpainter_fb_backend.cpp (15 lines)
M			plugins/platforms/virtual/scene_qpainter_virtual_backend.h (1 line)
M			plugins/platforms/virtual/scene_qpainter_virtual_backend.cpp (15 lines)
M			scene_qpainter.h (2 lines)
M			scene_qpainter.cpp (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4787	4862ced		Jun 28 2016, 8:39 AM	★	★
Diff 2	4840	23fb02c	rKWIN758d41d6bfa5b0c1b70c31b5a3de4ccd69becf7d	Jun 29 2016, 6:50 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
2c81da99647b	3ea96de4c003	4862ced95676	Martin Gräßlin	Paint the software cursor directly in SceneQPainter (Show More…)	Jun 28 2016, 8:37 AM

	Status	Author	Revision
	Closed	graesslin	D2028 Paint the software cursor directly in SceneQPainter
	Closed	graesslin	D2027 Render cursor in multi-screen setup in QPainter Compositor