Differential D20278

Replace MinimumComboBox with regular QComboBox
ClosedPublic
Actions

Authored by dvratil on Apr 5 2019, 5:46 PM.

Details

Reviewers
mlaurent
Commits
R91:b7ae99f21cbc: Replace MinimumComboBox with regular QComboBox
Summary

The size constraint can be set externally, we don't need to have a dedicated
widget for that.

Test Plan

Looks and behaves the same as before.

Diff Detail

Repository
R91 PIM: Sieve Handling Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Apr 5 2019, 5:46 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 5 2019, 5:46 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.Apr 5 2019, 5:46 PM
mlaurent added inline comments.Apr 5 2019, 6:47 PM
src/ksieveui/autocreatescripts/sieveactionwidgetlister.cpp
121

The idea of MinimumCombox was to define minimum width not maximum.
Here you force the maximum width no ?

mlaurent added a comment.Apr 5 2019, 6:55 PM

Why you don't port here too "sieveconditionwidgetlister.cpp" ?

dvratil updated this revision to Diff 55520.Apr 6 2019, 8:37 AM

Port remaining parts

mlaurent accepted this revision.Apr 6 2019, 10:30 AM
This revision is now accepted and ready to land.Apr 6 2019, 10:30 AM
Closed by commit R91:b7ae99f21cbc: Replace MinimumComboBox with regular QComboBox (authored by dvratil). · Explain WhyApr 6 2019, 2:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 55555

View Options

src/ksieveui/autocreatescripts/sieveactions/sieveactionremoveflags.cpp

Loading...
View Options

src/ksieveui/autocreatescripts/sieveactions/sieveactionsetflags.cpp

Loading...
View Options

src/ksieveui/autocreatescripts/sieveactionwidgetlister.h

Loading...
View Options

src/ksieveui/autocreatescripts/sieveactionwidgetlister.cpp

Loading...
View Options

src/ksieveui/autocreatescripts/sieveconditionwidgetlister.h

Loading...
View Options

src/ksieveui/autocreatescripts/sieveconditionwidgetlister.cpp

Loading...