Bump MLT dependency for Kdenlive
AbandonedPublic

Authored by mardelle on Apr 5 2019, 3:49 PM.

Details

Reviewers
cfeck
aacid
Summary

I am aware that this is really a last minute change, but MLT 6.14 was released 6 days ago and fixes several crashes that would impact Kdenlive users. It would be sad if Kdenlive was packaged against MLT 6.12.

If possible we would love to bump the dependency for the Kdenlive's 19.04 Application release

Test Plan

All developers/testers and AppImage use latest MLT git

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
mardelle requested review of this revision.Apr 5 2019, 3:49 PM
mardelle created this revision.
cfeck added a subscriber: Sysadmin.Apr 5 2019, 5:47 PM

Could you please check why our CI doesn't build kdenlive on commits to Applications/19.04 branch? I was going to check our CI, but it looks like kdenlive wasn't build since Mar 17.

https://build.kde.org/job/Applications/view/Everything%20-%20stable-kf5-qt5/job/kdenlive/job/stable-kf5-qt5%20SUSEQt5.10/

This is because as far as Jenkins is aware the correct branch to be tracking is Applications/18.10.
The most likely reasons for this are either:

  1. No build has been triggered since Applications/19.04 came into existence, probably because Applications/18.10 hasn't been committed to since March 17 and the Global Rebuild job hasn't been triggered.
  2. The metadata hasn't been updated for some reason or another, and it still points at Applications/18.10

I suspect #1 to be most likely here. I have pending changes to our Docker images, which in all likelihood will be Binary Incompatible and require a full rebuild of everything, so i'll trigger a Global Rebuild when that happens.
Unfortunately right now i'm blocked by PIM (sigh) because they've decided to do a bunch of version bumping commits to all their repositories, which is going to tie the CI system up for the next few hours (and then i'm likely to be blocked by scripty pushing translation changes...)

aacid added a comment.Apr 6 2019, 3:02 PM

the CI think may be due to the fact than when i branched i didn't do the branch for kdenlive since they were in the sprint, and i did the branch a few days later and may have forgotten to redo some stuff for CI.

About the dependency increase, is it really a "minimum requirement" or an "optimal requirement"?

If it's only optimal, make sure you email kde-distro-packagers@kde.org and tell them to make sure they have a good MLT (and maybe add a warning at cmake time). That should be enough IMHO, otherwise you're forcing people that may not have "a good enough MLT" to just not be able to use kdenlive at all.

Please commit this to master branch only for the coming 19.08 releases.

(Or 6.16 if that's what you would require)

cfeck added a comment.Jul 10 2019, 6:03 PM

This can be closed.

mardelle abandoned this revision.Jul 10 2019, 6:19 PM