Differential D20271

Take care of 'unused parameter' build warnings.
ClosedPublic
Actions

Authored by woltherav on Apr 5 2019, 3:22 PM.

Details

Reviewers

dkazakov

Group Reviewers

Krita

Commits

R37:4022dda53e7f: Clear build of all 'unused parameter' build warnings.

Summary

In an attempt at cleanup, I decided to take a look at the build warnings. This diff cleans up all unused parameters, but needs double checking to ensure it doesn't hide an unfinished something or the other.

Test Plan

Clean build. Ran, everything seems to work.

Diff Detail

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

woltherav requested review of this revision.Apr 5 2019, 3:22 PM

woltherav created this revision.

The patch looks fine. Please update the comment I noted inline and push

plugins/dockers/smallcolorselector/KisGLImageWidget.cpp
188	Please also change the comment below to // Fill with bright color as as default for debugging purposes

This revision is now accepted and ready to land.Apr 8 2019, 1:21 PM

Closed by commit R37:4022dda53e7f: Clear build of all 'unused parameter' build warnings. (authored by woltherav). · Explain WhyApr 8 2019, 1:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libs/image/tests/kis_filter_weights_applicator_test.cpp (2 lines)
M			libs/store/KoQuaZipStore.cpp (3 lines)
M			plugins/dockers/advancedcolorselector/kis_color_selector_component.h (2 lines)
M			plugins/dockers/advancedcolorselector/kis_color_selector_component.cpp (2 lines)
M			plugins/dockers/smallcolorselector/KisGLImageWidget.cpp (3 lines)
M			plugins/dockers/smallcolorselector/kis_small_color_widget.cc (4 lines)
M			plugins/paintops/gridbrush/kis_grid_paintop.cpp (2 lines)
M			plugins/paintops/hatching/kis_hatching_paintop.cpp (2 lines)
M			plugins/paintops/libpaintop/kis_clipboard_brush_widget.cpp (2 lines)
M			plugins/paintops/roundmarker/kis_roundmarkerop.cpp (2 lines)