clean
Needs RevisionPublic

Authored by carneirogustavo on Apr 5 2019, 1:11 AM.

Details

Summary

Signed-off-by: Gustavo Carneiro <gcarneiroa@hotmail.com>

Diff Detail

Repository
R410 KPatience
Branch
ts
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10455
Build 10473: arc lint + arc unit
carneirogustavo created this revision.Apr 5 2019, 1:11 AM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptApr 5 2019, 1:11 AM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
carneirogustavo requested review of this revision.Apr 5 2019, 1:11 AM

As a general suggestion, a commit message should convey the reason for the change. This is useful to any future consumer of the source repository, including the authors of the patches who will end up asking themselves "what did I mean by «clean» one year ago?".
Please take a look at: https://chris.beams.io/posts/git-commit/

tcanabrava requested changes to this revision.Apr 9 2019, 8:36 AM
tcanabrava added inline comments.
mainwindow.cpp
435

const auto features = QSet<QString> { items here };

This revision now requires changes to proceed.Apr 9 2019, 8:36 AM