Improve behavior of rotated displays
ClosedPublic

Authored by apol on Apr 4 2019, 6:17 PM.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Apr 4 2019, 6:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 4 2019, 6:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
apol requested review of this revision.Apr 4 2019, 6:17 PM
zzag added a subscriber: zzag.Apr 4 2019, 6:34 PM
zzag added inline comments.
plugins/platforms/drm/drm_output.cpp
130

Could you please explain this change?

147

QMatrix4x4 &&

152

Please follow coding style.

s / 2

181–199

I'd say that's abuse of auto even though the name contains "Matrix".

185

Please don't indent cases.

189

Why ry and rx?

apol marked 6 inline comments as done.Apr 4 2019, 11:51 PM
apol added inline comments.
plugins/platforms/drm/drm_output.cpp
130

We are using the result to check if there's orientation. It's not really a good idea to compare doubles to 0 so I changed to int.

apol updated this revision to Diff 55446.Apr 4 2019, 11:53 PM
apol marked an inline comment as done.

coding style

davidedmundson accepted this revision.Wed, Apr 24, 4:48 PM
This revision is now accepted and ready to land.Wed, Apr 24, 4:48 PM
zzag added inline comments.Wed, Apr 24, 5:34 PM
plugins/platforms/drm/drm_output.cpp
147
QMatrix4x4 &&DrmOutput::
plugins/platforms/drm/drm_output.h
138

Please add a whitespace between "&&" and the method name.

apol edited the summary of this revision. (Show Details)Thu, Apr 25, 12:19 AM
This revision was automatically updated to reflect the committed changes.