Make the Configuration button more understandable
AbandonedPublic

Authored by trmdi on Apr 4 2019, 2:10 PM.

Details

Reviewers
rooty
mvourlakos
Group Reviewers
Latte Dock
Summary

Without the button background, it's difficult to realize that it's a button.

Test Plan

Before:


After:

Diff Detail

Repository
R878 Latte Dock
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10462
Build 10480: arc lint + arc unit
trmdi created this revision.Apr 4 2019, 2:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 4 2019, 2:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Apr 4 2019, 2:10 PM

screenshots please

mvourlakos requested changes to this revision.Apr 4 2019, 2:27 PM
This revision now requires changes to proceed.Apr 4 2019, 2:27 PM
trmdi edited the test plan for this revision. (Show Details)Apr 4 2019, 2:42 PM

I am not sure...
I think would prefer a hovering mechanism, a rectangle with transparency e.g. 0.5 when this option is hovered

trmdi added a comment.Apr 4 2019, 3:01 PM

I think would prefer a hovering mechanism, a rectangle with transparency e.g. 0.5 when this option is hovered

How would the user know it's a button to hover it?
He's unlikely to know that's a button until he hovers over it randomly.

he will be educated to do so

trmdi updated this revision to Diff 55472.EditedApr 5 2019, 1:14 PM

Set hoverColor

mvourlakos added inline comments.Apr 5 2019, 1:52 PM
containment/package/contents/ui/editmode/HeaderSettings.qml
87

this should be :

backgroundColor: containsMouse? colorizerManager.buttonHoverColor : "transparent"

and how does it look when the button in activated ?

filipf added a subscriber: filipf.Apr 5 2019, 9:02 PM

Hey @trmdi rooty's not participating in KDE at this point so he won't be able to do the review.

Just so I don't stop by without giving a contribution: I like the idea of making it more obvious that it's a button. Maybe you could reach a compromise here and have the background at quite a low opacity when not hovered over, perhaps have this sort of an effect: https://youtu.be/hR_AV1bCS5g?t=12

Following the comments I have updated a bit the Rearrange button, these are some results with the new approach:

normal:

hovered:

normal:

hovered:

trmdi abandoned this revision.Apr 7 2019, 2:23 AM