Differential D20246

Fix results of Nearest Neighbour filter
ClosedPublic
Actions

Authored by tymond on Apr 4 2019, 9:28 AM.

Details

Reviewers

dkazakov

Group Reviewers

Krita

Commits

R37:57c3194c1c8a: Fix results of Nearest Neighbour filter

Summary

Before this patch the NN filter would create intermediate colors
in some circumstances, especially when scaling with the scale <50%.
Now the filter will choose one of the colors around instead of
blending colors around to get the result color.

BUG:401788

Test Plan

added tests to test the behaviour of NN filter
testing on the image: http://www.bealecorner.org/red/test-patterns/star-chart-bars144-600dpi.png
testing on the image from bug report

Diff Detail

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tymond created this revision.Apr 4 2019, 9:28 AM

Restricted Application added a reviewer: Krita. · View Herald TranscriptApr 4 2019, 9:28 AM

Restricted Application added a project: Krita. · View Herald Transcript

tymond requested review of this revision.Apr 4 2019, 9:28 AM

Harbormaster completed remote builds in B10429: Diff 55400.Apr 4 2019, 9:28 AM

Removed last parts of debug.

Harbormaster completed remote builds in B10430: Diff 55406.Apr 4 2019, 9:55 AM

The patch looks and works fine, please push! :)

This revision is now accepted and ready to land.Apr 4 2019, 10:23 AM

Closed by commit R37:57c3194c1c8a: Fix results of Nearest Neighbour filter (authored by tymond). · Explain WhyApr 5 2019, 8:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libs/image/kis_filter_strategy.h (40 lines)
M			libs/image/kis_filter_strategy.cc (47 lines)
M			libs/image/kis_filter_weights_applicator.h (9 lines)
M			libs/image/kis_filter_weights_buffer.h (11 lines)
M			libs/image/kis_transform_worker.cc (2 lines)
M			libs/image/tests/kis_filter_weights_applicator_test.h (10 lines)
M			libs/image/tests/kis_filter_weights_applicator_test.cpp (229 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	55400	3a4bfb2		Apr 4 2019, 9:28 AM	★	★
Diff 2	55406	3a4bfb2	Removed last parts of debug.	Apr 4 2019, 9:55 AM	★	★
Diff 3	55458	0cf7c06	R37:57c3194c1c8aaf9b17fd8f080533610c38a626a7	Apr 5 2019, 8:33 AM	★	★