Add syntax highlighting for fish shell
ClosedPublic

Authored by adiestelhorst on Apr 3 2019, 6:46 PM.

Details

Summary

FEATURE: 381396

For fish shell version 2.7.1

References
http://fishshell.com/

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adiestelhorst created this revision.Apr 3 2019, 6:46 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptApr 3 2019, 6:46 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
adiestelhorst requested review of this revision.Apr 3 2019, 6:46 PM
nibags edited the summary of this revision. (Show Details)Apr 5 2019, 8:24 PM
cullmann requested changes to this revision.Apr 5 2019, 8:29 PM

Thanks for the contribution.
On a first glance, that looks ok, no hard coded colors, test case, ...
We would prefer if the license would be MIT, is that possible?

This revision now requires changes to proceed.Apr 5 2019, 8:29 PM

Thanks for the contribution.
On a first glance, that looks ok, no hard coded colors, test case, ...
We would prefer if the license would be MIT, is that possible?

That's fine by me. But when you compare the xml to that of bash (which is LGPL), you will find some similarities, which are not by accident. I originally started out from that file because that is a fast way to start. Nearly everything has changed since, but I cannot judge, whether a change of license would be ok.

If you think you nearly changed everything, I guess MIT is ok.
If you think still too much is derived, I can live with LGPL ;=)
I let you decide.

I found nothing helpfull for this question. There is still the list of Unix commands, where I did only small additions and which is nearly half the lines of code.
When in doubt, I think it is better to stick to the rules. So I would like to keep it LGPL.

Maybe, you can convince the authors of the other definitions to switch to MIT. In that case, I would also do it.

cullmann accepted this revision.Apr 10 2019, 9:00 AM

Ok, then we keep that license and push this as is.

Thanks for the contribution, btw.!

This revision is now accepted and ready to land.Apr 10 2019, 9:00 AM
This revision was automatically updated to reflect the committed changes.