Differential D20217

Remove kwallet4 support
ClosedPublic
Actions

Authored by davidedmundson on Apr 2 2019, 9:55 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R107:905b00d38040: Remove kwallet4 support
Summary

Kwallet5 migrates the old wallet and kdelibs4 code can connect to the
kwalletd5 daemon.

I can't envision any situation where a person would need to be compiling
the latest version of this Plasma code without having the KF5 wallet
runtime.

Test Plan

N/A

Diff Detail

Repository
R107 KWallet PAM Integration
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10383
Build 10401: arc lint + arc unit
davidedmundson created this revision.Apr 2 2019, 9:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 2 2019, 9:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Apr 2 2019, 9:55 PM
apol accepted this revision.Apr 2 2019, 10:20 PM
This revision is now accepted and ready to land.Apr 2 2019, 10:20 PM
Closed by commit R107:905b00d38040: Remove kwallet4 support (authored by davidedmundson). · Explain WhyApr 3 2019, 10:56 AM
This revision was automatically updated to reflect the committed changes.
arrowd added a subscriber: arrowd.May 3 2023, 9:03 AM
arrowd added inline comments.
pam_kwallet.c
436

I wonder why one of NULL wasn't removed completely?

meven added a subscriber: meven.May 3 2023, 4:08 PM
meven added inline comments.
pam_kwallet.c
436

The first of the NULL replaced extraArg naively.
You can send a simple MR for this.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)
Mpam_kwallet.c (34 lines)
Mpam_kwallet_init (4 lines)

Diff 55317

View Options

CMakeLists.txt

Loading...
View Options

pam_kwallet.c

Loading...
View Options

pam_kwallet_init

Loading...