Differential D20213

[kcolorschemeeditor] Use config path instead of searching again
ClosedPublic
Actions

Authored by broulik on Apr 2 2019, 8:22 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:c0b1a7e16e69: [kcolorschemeeditor] Use config path instead of searching again
Summary

m_schemeName is the translated scheme name which may not match the file name.
Since the config is always opened with an absolute path, we can just use the config's name.

BUG: 399951

Test Plan

I'll try putting that into 5.15 (but gonna be tough since the color kcm rewrite happened)

  • Ran kcolorschemeeditor "BreezeHighContrast" tried to upload, it got the correct /usr/share/color-schemes/BreezeHighContrast.colors path
  • Changed the scheme, saved it under a different name, tried to upload, it got the correct ~/.local/share/color-schemes/NewScheme.colors path

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 2 2019, 8:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 2 2019, 8:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 2 2019, 8:22 PM
davidedmundson accepted this revision.Apr 10 2019, 8:11 PM
This revision is now accepted and ready to land.Apr 10 2019, 8:11 PM
Closed by commit R119:c0b1a7e16e69: [kcolorschemeeditor] Use config path instead of searching again (authored by broulik). · Explain WhyApr 11 2019, 7:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/colors/scmeditordialog.cpp (11 lines)

Diff 55968

View Options

kcms/colors/scmeditordialog.cpp

Loading...