Differential D20191

Proof of concept of a wayland protocol to allow the keystate dataengine to work
ClosedPublic
Actions

Authored by apol on Apr 1 2019, 11:51 PM.

Tags

Subscribers

davidedmundson, kde-frameworks-devel

Details

Reviewers

Group Reviewers

Commits

R127:71cbb548e0ad: Proof of concept of a wayland protocol to allow the keystate dataengine to work

Test Plan

Tested with both the lock screen and the keyboard indicator plasmoid

Diff Detail

Repository

Branch

master

Lint

Lint Skipped

Excuse: x

Unit

No Unit Test Coverage

Build Status

Buildable 10704
Build 10722: arc lint + arc unit

apol created this revision.Apr 1 2019, 11:51 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 1 2019, 11:51 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

apol requested review of this revision.Apr 1 2019, 11:51 PM

Harbormaster completed remote builds in B10352: Diff 55247.Apr 1 2019, 11:51 PM

apol added a dependent revision: D20192: Implement the keystate protocol.Apr 1 2019, 11:53 PM

davidedmundson added a subscriber: davidedmundson.Apr 2 2019, 12:12 PM

davidedmundson added inline comments.

src/client/protocols/keystate.xml
35	I would just send the initial stateChanged on bind

apol added a dependent revision: D20193: Expose locked keystates on KModifierKeyInfo when on wayland.Apr 2 2019, 4:00 PM

Include keystates client side

Harbormaster completed remote builds in B10704: Diff 55913.Apr 10 2019, 3:15 PM

davidedmundson accepted this revision.Jun 20 2019, 2:38 PM

davidedmundson added inline comments.

src/server/display.h
207	please keep up to date.
src/server/keystate_interface.cpp
89	->

This revision is now accepted and ready to land.Jun 20 2019, 2:38 PM

Closed by commit R127:71cbb548e0ad: Proof of concept of a wayland protocol to allow the keystate dataengine to work (authored by apol). · Explain WhyJun 22 2019, 11:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/client/CMakeLists.txt (6 lines)
A	M		src/client/keystate.h (81 lines)
A	M		src/client/keystate.cpp (81 lines)
A	M		src/client/protocols/keystate.xml (43 lines)
M			src/client/registry.h (32 lines)
M			src/client/registry.cpp (11 lines)
M			src/server/CMakeLists.txt (7 lines)
M			src/server/display.h (5 lines)
M			src/server/display.cpp (8 lines)
A	M		src/server/keystate_interface.h (71 lines)
A	M		src/server/keystate_interface.cpp (96 lines)

Diff 55913

src/client/CMakeLists.txt

Loading...

src/client/keystate.h

Loading...

src/client/keystate.cpp

Loading...

src/client/protocols/keystate.xml

Loading...

src/client/registry.h

Loading...

src/client/registry.cpp

Loading...

src/server/CMakeLists.txt

Loading...

src/server/display.h

Loading...

src/server/display.cpp

Loading...

src/server/keystate_interface.h

Loading...

src/server/keystate_interface.cpp

Loading...