Fix showing update notification
ClosedPublic

Authored by broulik on Apr 1 2019, 10:21 AM.

Details

Summary

Updates variables first before checking state() which depends on them

Test Plan
  • I now get a "updates available" notification on login again

I would suggest to add a unittest to the notifier as this thing seems to break every other release and not telling people about updates is bad

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 1 2019, 10:21 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 1 2019, 10:21 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 1 2019, 10:21 AM
apol accepted this revision.Apr 1 2019, 12:36 PM
This revision is now accepted and ready to land.Apr 1 2019, 12:36 PM
This revision was automatically updated to reflect the committed changes.