Fix crash when applying collection ACL changes
ClosedPublic

Authored by dvratil on Apr 1 2019, 9:36 AM.

Details

Summary

Another regression caused by switch to const/non-const attributes.

BUG: 405975
FIXED-IN: 5.11

Test Plan

Couldn't reproduce the crash described in the bug report, but the backtrace
is fairly obvious.

Diff Detail

Repository
R95 PIM: Common Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Apr 1 2019, 9:36 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 1 2019, 9:36 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.Apr 1 2019, 9:36 AM

I can reproduce the crash reliably (Configure folder -> set mailing list properties -> OK -> crash). I'll test this patch and see what happens.

@lbeltrame did you have a chance to look at this? We should make sure it's fixed before the final 19.04 release.

dvratil updated this revision to Diff 55270.Apr 2 2019, 12:10 PM

Ensure the Collection outlives the attribute, should fix the crash for good.

lbeltrame accepted this revision.Apr 3 2019, 8:34 AM

Works now, I can't reproduce the crash anymore.

This revision is now accepted and ready to land.Apr 3 2019, 8:34 AM
This revision was automatically updated to reflect the committed changes.