Differential D20155

[SpinBox] Improve mouse wheel behavior
ClosedPublic
Actions

Authored by broulik on Apr 1 2019, 8:43 AM.

Tags

Subscribers

abetts, davidedmundson, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R858:8f4ac7abc600: [SpinBox] Improve mouse wheel behavior

Summary

Emit valueChanged signal since this is an explicit user interaction.
Also, enforce "steps" for high precision touchpad scrolling.

Test Plan

Scrolling with touchpad no longer makes it go crazy
Scrolling with mousewheel still works as expected
Changing value with wheel has the same effect now as clicking the arrow buttons

Diff Detail

Repository

R858 Qt Quick Controls 2: Desktop Style

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Apr 1 2019, 8:43 AM

Restricted Application added a project: Plasma. · View Herald TranscriptApr 1 2019, 8:43 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Apr 1 2019, 8:43 AM

broulik edited the test plan for this revision. (Show Details)

davidedmundson added a subscriber: davidedmundson.Apr 1 2019, 8:50 AM

davidedmundson added inline comments.

org.kde.desktop/SpinBox.qml
74	Does this match the widget? It seems sensible if you you had two physical wheels, if it was exposed as a scroll-ball, this behaviour seems a bit weird.

Can you add a before/after video maybe? Just to see the changes

Only use y delta, which is what QAbstractSpinBox does

davidedmundson accepted this revision.Apr 1 2019, 8:59 PM

This revision is now accepted and ready to land.Apr 1 2019, 8:59 PM

Closed by commit R858:8f4ac7abc600: [SpinBox] Improve mouse wheel behavior (authored by broulik). · Explain WhyApr 2 2019, 12:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			org.kde.desktop/SpinBox.qml (20 lines)

Diff 55170

org.kde.desktop/SpinBox.qml

Loading...