Raise notifications with KeepAbove flag to OnScreenDisplay layer
AbandonedPublic

Authored by broulik on Apr 1 2019, 8:41 AM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Summary

Allows the notification server to keep critical notifications on top of e.g. fullscreen windows.

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 1 2019, 8:41 AM
Restricted Application added a project: KWin. · View Herald TranscriptApr 1 2019, 8:41 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Apr 1 2019, 8:41 AM
zzag added a subscriber: zzag.Apr 1 2019, 10:11 AM

Hmm, looks okay to me though it probably won't work on Wayland (at least right now).

graesslin requested changes to this revision.Apr 1 2019, 7:47 PM
graesslin added a subscriber: graesslin.

Please don't introduce such magic. If you need a special window type please add one or use osd directly. Please keep in mind that there's no way to set keep above for Wayland windows.

This revision now requires changes to proceed.Apr 1 2019, 7:47 PM
broulik planned changes to this revision.Apr 9 2019, 6:42 PM

Will introduce a CriticalNotification window type then

I can make you a new layer if you want. There's also D18365 to make keep above work.

broulik requested review of this revision.Apr 16 2019, 11:07 AM
broulik abandoned this revision.Apr 17 2019, 8:23 AM